Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upClean up and misc fixes #196
Merged
Conversation
Since webrender 0.58 has changed his API.
Don't creata an image key per frame, neither add an image per frame, just one and later only update the image data. The image key and the image are destroyed if the frame resolution changes.
Also the frame interchange is mutexed, thus no flickering.
There is no need to pass a reference to an Arc'd vector, let's just return the cloned vector.
|
@ferjm +? |
bors-servo
added a commit
that referenced
this pull request
Feb 21, 2019
Negotiate GL textures and render them in player example This PR goes above PR #196 It needs to update the CI GStreamer setup, because it requires a new version of glib and gstreamer-gl library. It contains * Port to webrender 0.58 * Port to gstreamer git head version (0.13.0) -- this implied a complete rewrite of servosrc * Add a new trait in Frame to hold a reference to the backend's buffer * Update glutin version tu current git head * Add a method to set the GL parameters in the backend's player * Use glsinkbin in gstreamer player in GL parameters are negotiated * A lot of changes in example player to render gl textures is --gl argument is passed Fixes: #166
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
ceyusa commentedFeb 8, 2019
This pull request is a preparation for the video frames rendering as gl textures in the player example: