Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up and misc fixes #196

Merged
merged 7 commits into from Feb 8, 2019
Merged

Clean up and misc fixes #196

merged 7 commits into from Feb 8, 2019

Conversation

@ceyusa
Copy link
Contributor

ceyusa commented Feb 8, 2019

This pull request is a preparation for the video frames rendering as gl textures in the player example:

  • isolate the video sinks setup in a function
  • add gst logging capabilities to gstreamer player backend, rather than use print macros
  • specify a specific commit id to webrender, since we are using git head, but an update will break our example app
  • use glib and gstreamer preludes, this is a general clean up recommended by @sdroege
  • the player example eats all the available memory since a great big image leak
  • instead of keeping a vector with pushed frames from player example, add a custom queue with only three frames
  • as we are using Arc'ed data, there's no need to return a reference
ceyusa added 7 commits Jan 11, 2019
Since webrender 0.58 has changed his API.
Don't creata an image key per frame, neither add an image per frame,
just one and later only update the image data.

The image key and the image are destroyed if the frame resolution
changes.
Also the frame interchange is mutexed, thus no flickering.
There is no need to pass a reference to an Arc'd vector, let's just
return the cloned vector.
@ceyusa
Copy link
Contributor Author

ceyusa commented Feb 8, 2019

@ferjm +?

@ferjm ferjm merged commit 0a7f400 into servo:master Feb 8, 2019
1 check passed
1 check passed
Travis CI - Pull Request Build Passed
Details
@ceyusa ceyusa deleted the ceyusa:misc-fixes branch Feb 11, 2019
bors-servo added a commit that referenced this pull request Feb 21, 2019
Negotiate  GL textures and render them in player example

This PR goes above PR #196

It needs to update the CI GStreamer setup, because it requires  a new version of glib and gstreamer-gl library.

It contains

* Port to webrender 0.58
* Port to gstreamer git head version (0.13.0) -- this implied a complete rewrite of servosrc
* Add a new trait in Frame to hold a reference to the backend's buffer
* Update glutin version tu current git head
* Add a method to set the GL parameters in the backend's player
* Use glsinkbin in gstreamer player in GL parameters are negotiated
* A lot of changes in example player to render gl textures is --gl argument is passed

Fixes: #166
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.