Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upCreate servo-media-streams crate, allow specifying capture constraints #199
+129
−82
Conversation
bors-servo
added a commit
to servo/servo
that referenced
this pull request
Feb 13, 2019
Update servo-media Pulls in servo/media#199, doesn't use it yet <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22872) <!-- Reviewable:end -->
bors-servo
added a commit
to servo/servo
that referenced
this pull request
Feb 13, 2019
Update servo-media Pulls in servo/media#199, doesn't use it yet <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22872) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Manishearth commentedFeb 12, 2019
•
edited by jdm
Created a toplevel crate for all the streams stuff so that it doesn't have to live inside webrtc. Also exposed the constraints parameter so that clients may constrain getUserMedia requests. Fixes #192.