Skip to content

/ media

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AudioStream improvements #2

Merged
merged 5 commits into from Apr 19, 2018
Merged

AudioStream improvements #2

merged 5 commits into from Apr 19, 2018

Conversation

@philn
Copy link
Collaborator

philn commented Apr 18, 2018

No description provided.

philn added 5 commits Apr 18, 2018
@philn
Reformat audio_stream.rs with rustfmt
aee56fd
@philn
Cleanup audio_stream a bit
5044baa 
No need to call gst::init() more than once, it's called already in the GStreamer
impl. Also capture the set_state() result in stop.
@philn
Reformat src_element with Rustfmt
3127e7c
@philn
Dummy URI handling support for the audio source element
0af1952
@philn
Port AudioStream to GstPlayer
ba1316d 
The test now also completes after 5 seconds of playback.
@ferjm
ferjm approved these changes Apr 19, 2018
View changes
Copy link
Member

ferjm left a comment

Thank you!
@ferjm ferjm merged commit 63fb114 into servo:master Apr 19, 2018
Manishearth pushed a commit to Manishearth/media that referenced this pull request Jan 17, 2019
@jdm
Merge pull request servo#2 from Manishearth/watever
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
efe5e62 
local description
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ferjm ferjm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@philn @ferjm
You can’t perform that action at this time.