Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ulong is u32, not u64 #200

Merged
merged 2 commits into from Feb 13, 2019
Merged

ulong is u32, not u64 #200

merged 2 commits into from Feb 13, 2019

Conversation

@Manishearth
Copy link
Member

Manishearth commented Feb 13, 2019

No description provided.

@Manishearth
Copy link
Member Author

Manishearth commented Feb 13, 2019

r? @jdm

@Manishearth Manishearth force-pushed the Manishearth:ulong branch from afb6013 to 8cae7b8 Feb 13, 2019
@jdm jdm merged commit d2ed90a into servo:master Feb 13, 2019
2 checks passed
2 checks passed
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
@sdroege
Copy link
Contributor

sdroege commented Feb 13, 2019

Where does the ulong come from exactly? If there's really a C unsigned long / gulong somewhere here then this change is wrong. unsigned long is 64 bit on all 64 bit architectures except for Windows.

@sdroege
Copy link
Contributor

sdroege commented Feb 13, 2019

Use libc::c_ulong if you need the correct type, btw

@Manishearth
Copy link
Member Author

Manishearth commented Feb 13, 2019

@sdroege
Copy link
Contributor

sdroege commented Feb 13, 2019

Oh how confusing. Nevermind then :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.