Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upMake sink code work again #208
Merged
+160
−159
Conversation
This was referenced Feb 21, 2019
Manishearth
changed the title
|
Ready for review r? @jdm |
|
The issues were:
|
|
|
Merged
|
Addressed. Looks like requesting I still have to prerequest pads, though. |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Mar 2, 2019
|
|
bors-servo
added a commit
that referenced
this pull request
Mar 2, 2019
Fix sink pad ordering Fixes #210 Based on #208 This implements a version of the fix detailed in #210 (comment) Instead of unlinking/relinking, we simply keep new streams unlinked until we decide to trigger an offer, at which point we link them to new request pads. The answerer side keeps them unlinked until it gets a remote offer, at which point it also requests pads and links them to the correctly numbered request pads. A missing piece was that the payload number also has to match, so we keep track of that too. r? @jdm @slomo (last two commits only)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Manishearth commentedFeb 21, 2019
•
edited
fixes #191