Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upInvert dependency graph for backends #209
Merged
Conversation
|
The changes for Servo to use this new model are quite short: servo/servo@master...jdm:media-invert |
|
Thanks for doing this! r=me |
audio/src/render_thread.rs
Outdated
| @@ -12,7 +12,7 @@ use node::{BlockInfo, ChannelInfo}; | |||
| use offline_sink::OfflineAudioSink; | |||
| use oscillator_node::OscillatorNode; | |||
| use panner_node::PannerNode; | |||
| use sink::{AudioSink, AudioSinkError, DummyAudioSink}; | |||
| use sink::{AudioSink, AudioSinkError/*, DummyAudioSink*/}; | |||
This comment has been minimized.
This comment has been minimized.
audio/src/render_thread.rs
Outdated
| Err((_graph, e)) => { | ||
| error!("Could not start audio render thread due to error `{:?}`", e); | ||
| assert!(false); | ||
| /*error!( |
This comment has been minimized.
This comment has been minimized.
servo-media/src/lib.rs
Outdated
| DummyWebRtcController | ||
| } | ||
| pub trait Backend: Send + Sync { | ||
| fn make_player(&self) -> Box<Player>; |
This comment has been minimized.
This comment has been minimized.
ferjm
Feb 25, 2019
Member
uber-nit: s/make_player/create_player/g as all the other methods are create_*.
backends/dummy/Cargo.toml
Outdated
| servo-media-audio = { path = "../../audio" } | ||
| servo-media-player = { path = "../../player" } | ||
| servo-media-streams = { path = "../../streams" } | ||
| servo-media-webrtc = { path = "../../webrtc" } |
This comment has been minimized.
This comment has been minimized.
servo-media/Cargo.toml
Outdated
| @@ -18,5 +18,8 @@ path = "../streams" | |||
| [dependencies.servo-media-webrtc] | |||
| path = "../webrtc" | |||
|
|
|||
| [target.'cfg(any(all(target_os = "android", target_arch = "arm"), target_arch = "x86_64"))'.dependencies.servo-media-gstreamer] | |||
| path = "../backends/gstreamer" | |||
| #[target.'cfg(any(all(target_os = "android", target_arch = "arm"), target_arch = "x86_64"))'.dependencies.servo-media-gstreamer] | |||
This comment has been minimized.
This comment has been minimized.
|
The reason we initially chose the other model was mostly that it was easier, and we didn't expect other backends. But the dummy backend is turning out to be pretty important, so it's probably good to have it supported better. I doubt the trait object costs are major here. |
|
@bors-servo r=Manishearth,ferjm |
|
|
bors-servo
added a commit
that referenced
this pull request
Mar 1, 2019
Invert dependency graph for backends This change has several benefits: * it makes the backend selection explicit by the user of this library (which ensures that it's easy to test that the dummy backend compiles) * it moves the platform-based backend selection into its own optional crate and reduces duplication * it makes the backends depend on servo-media, rather than the reverse, which improves build times for Servo when the public media APIs are not modified The downside is there are more trait objects instead of static types. My suspicion is that the performance hit of using virtual methods here is dwarfed by the other work being done, but I have not attempted to measure this at all.
|
|
|
@bors-servo r=Manishearth,ferjm |
|
|
bors-servo
added a commit
that referenced
this pull request
Mar 1, 2019
Invert dependency graph for backends This change has several benefits: * it makes the backend selection explicit by the user of this library (which ensures that it's easy to test that the dummy backend compiles) * it moves the platform-based backend selection into its own optional crate and reduces duplication * it makes the backends depend on servo-media, rather than the reverse, which improves build times for Servo when the public media APIs are not modified The downside is there are more trait objects instead of static types. My suspicion is that the performance hit of using virtual methods here is dwarfed by the other work being done, but I have not attempted to measure this at all. Fixes #194.
|
|
…nstantiating the media stack.
|
@bors-servo r=Manisheart,ferjm |
|
|
bors-servo
added a commit
that referenced
this pull request
Mar 1, 2019
Invert dependency graph for backends This change has several benefits: * it makes the backend selection explicit by the user of this library (which ensures that it's easy to test that the dummy backend compiles) * it moves the platform-based backend selection into its own optional crate and reduces duplication * it makes the backends depend on servo-media, rather than the reverse, which improves build times for Servo when the public media APIs are not modified The downside is there are more trait objects instead of static types. My suspicion is that the performance hit of using virtual methods here is dwarfed by the other work being done, but I have not attempted to measure this at all. Fixes #194.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
jdm commentedFeb 22, 2019
•
edited
This change has several benefits:
The downside is there are more trait objects instead of static types. My suspicion is that the performance hit of using virtual methods here is dwarfed by the other work being done, but I have not attempted to measure this at all.
Fixes #194.