Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upPlayer shutdown #212
Merged
Player shutdown #212
Conversation
|
r? @ceyusa |
| fn shutdown(&self) -> Result<(), PlayerError> { | ||
| self.observers.lock().unwrap().clear(); | ||
| self.renderers.lock().unwrap().clear(); | ||
| self.stop() |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ferjm
Feb 25, 2019
Author
Member
Stopping will trigger shutdown related messages (i.e. state change message) that observers may not be able to handle anymore. Since this is an active request to shutdown it is safe to assume that the client already knows about the shutdown related notifications and makes the API easier to use (i.e. the client does not need to keep a shutdown flag to discard shutdown messages).
This comment has been minimized.
This comment has been minimized.
|
r+ |
|
@bors-servo r=ceyusa |
|
|
bors-servo
added a commit
that referenced
this pull request
Feb 25, 2019
Player shutdown This should allow us to fix issues like servo/servo#22931
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
ferjm commentedFeb 25, 2019
This should allow us to fix issues like servo/servo#22931