Skip to content

/ media

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proper Webrtc error type #215

Merged
merged 4 commits into from Mar 5, 2019
Merged

Add proper Webrtc error type #215

merged 4 commits into from Mar 5, 2019

Conversation

@Manishearth
Copy link
Member

Manishearth commented Mar 5, 2019

fixes #206
Manishearth added 3 commits Mar 5, 2019
@Manishearth
Rudimentary WebrtcError type
8d7a94f
@Manishearth
Get rid of self.webrtc unwraps in favor of One Unwrap To Rule Them All
47afc70
@Manishearth
Move all unwraps to ?
Loading status checks…
381c25a
@Manishearth Manishearth force-pushed the Manishearth:error-handling branch from 9b972db to 381c25a Mar 5, 2019
@Manishearth
Some things should be expect()s
Loading status checks…
8582869
@Manishearth
Copy link
Member Author

Manishearth commented Mar 5, 2019

I'm not sure exactly which things should use ? and which should be expect().

The errors are just printed out and not reported to the client, there is a burden of ensuring things happen in the correct order on the client side, however due to the messaging model there's no nonblocking way to let this library handle errors and report back.
@Manishearth Manishearth mentioned this pull request Mar 5, 2019
Merged
@jdm
Copy link
Member

jdm commented Mar 5, 2019

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Mar 5, 2019

📌 Commit 8582869 has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Mar 5, 2019

⌛ Testing commit 8582869 with merge 058c329...
bors-servo added a commit that referenced this pull request Mar 5, 2019
@bors-servo
Auto merge of #215 - Manishearth:error-handling, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
058c329 
Add proper Webrtc error type

fixes #206
@bors-servo
Copy link
Contributor

bors-servo commented Mar 5, 2019

☀️ Test successful - checks-travis
Approved by: jdm
Pushing 058c329 to master...
@bors-servo bors-servo merged commit 8582869 into servo:master Mar 5, 2019
2 checks passed
2 checks passed
Travis CI - Pull Request Build Passed
Details
homu Test successful
Details
bors-servo added a commit that referenced this pull request Mar 5, 2019
@bors-servo
Auto merge of #218 - Manishearth:state-changes, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
31a82a0 
Add signaling, gathering, and ICE connection state callbacks

based on #215 (but largely independent, this is only to avoid merge conflicts later)

fixes #216

r? @jdm
@Manishearth Manishearth deleted the Manishearth:error-handling branch Mar 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Handle webrtc errors better
3 participants
@Manishearth @jdm @bors-servo
You can’t perform that action at this time.