Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAvoid race between set-remote-description and link_streams #226
Conversation
It is possible for link_streams to be called when our code has received a remote offer (and thus `remote_mline_info` is set), but before `set-remote-description` has completely finished executing. This can lead to `link_streams` _thinking_ that the webrtcbin is ready to create new pads, while the internal transceivers haven't yet been created. Thus even though we link streams to the appropriate pads, the transceivers are created in the wrong order, and some of the gstreamer code looks at transceiver creation order instead of mline info (this is a bug), breaking things. fixes ##225
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Mar 29, 2019
Avoid race between set-remote-description and link_streams It is possible for link_streams to be called when our code has received a remote offer (and thus `remote_mline_info` is set), but before `set-remote-description` has completely finished executing. This can lead to `link_streams` _thinking_ that the webrtcbin is ready to create new pads, while the internal transceivers haven't yet been created. Thus even though we link streams to the appropriate pads, the transceivers are created in the wrong order, and some of the gstreamer code looks at transceiver creation order instead of mline info (this is a bug), breaking things. fixes ##225 r? @jdm
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Manishearth commentedMar 29, 2019
•
edited
It is possible for link_streams to be called when our code has received a remote offer (and thus
remote_mline_infois set), but beforeset-remote-descriptionhas completely finished executing. This can lead tolink_streamsthinking that the webrtcbin is ready to create new pads, while the internal transceivers haven't yet been created. Thus even though we link streams to the appropriate pads, the transceivers are created in the wrong order, and some of the gstreamer code looks at transceiver creation order instead of mline info (this is a bug), breaking things.fixes #225
r? @jdm