Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFlatten directory structures #229
Merged
+12
−0
Conversation
|
This will cause some conflicts in #227, I'm open to landing this without the last three commits if you don't want to deal with that (git's tooling around rename rebases can be weird) |
|
We should also probably consistently name the crates, but I'll do that later. |
|
done.
-Manish Goregaokar
…On Sun, Mar 31, 2019 at 11:11 PM Fernando Jiménez Moreno < ***@***.***> wrote:
This will cause some conflicts in #227
<#227>, I'm open to landing this
without the last three commits if you don't want to deal with that (git's
tooling around rename rebases can be weird)
I would appreciate that, thanks. I can apply the changes after #227
<#227> lands.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#229 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABivSC6n_PkfMSP32L6VpRkL-sb_WpPLks5vcaMIgaJpZM4cUDmJ>
.
|
|
Thanks! @bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Apr 1, 2019
Flatten directory structures The `src/` model is nice for when your repository has a single crate in it, and the root directory gets cluttered with a bunch of random other files making it hard to find your code. However, this repo contains many crates all in their own folders, so there's no need for having `src/` here. This is similar to what Servo does for all of its `components/` crates, files fall directly under `components/foo` and not `components/foo/src`. Overall this makes this repository nicer to navigate. r? @ferjm
|
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Manishearth commentedMar 31, 2019
The
src/model is nice for when your repository has a single crate in it, and the root directory gets cluttered with a bunch of random other files making it hard to find your code. However, this repo contains many crates all in their own folders, so there's no need for havingsrc/here. This is similar to what Servo does for all of itscomponents/crates, files fall directly undercomponents/fooand notcomponents/foo/src.Overall this makes this repository nicer to navigate.
r? @ferjm