Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upStreams registry #233
Streams registry #233
Conversation
|
r? @Manishearth |
|
Is there a reason the streams registry is only in the gstreamer backend? I'd imagine that the registry would be common to all backends. There will be client implementations of MediaStream eventually, for example. (since the DOM can write custom media streams) |
|
eventually we'll probably want to switch this over to an event loop model, but that's only for when we move all of servo-media to its own process, which comes much later, and can be done pretty easily. |
No specific reason. It makes sense to share it among backends. I'll update the patch tomorrow. Thanks! |
|
I've just updated the PR with the suggested change. |
| fn create_audiostream(&self) -> Box<MediaStream> { | ||
| Box::new(DummyMediaStream) | ||
| fn create_audiostream(&self) -> MediaStreamId { | ||
| MediaStreamId::new() |
This comment has been minimized.
This comment has been minimized.
Manishearth
Apr 4, 2019
Member
Should the dummy backend be registering dummy streams instead? register_stream(Box::new(DummyStream))?
|
r=me with or without the comment being addressed |
|
@bors-servo r=Manishearth |
|
|
|
|
ferjm commentedApr 3, 2019
No description provided.