Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add trait PlayerGLContext #241

Merged
merged 2 commits into from Apr 30, 2019

Conversation

Projects
None yet
3 participants
@ceyusa
Copy link
Contributor

commented Apr 21, 2019

PlayerGLContext will provide the GL context paratemers required to
create a Render object. If those parameters are supported by the
Render, it will setup a GL rendering pipeline and will handle the
frames in form of GL Textures.

The PlayerGLContext is passed to the player at its instantiation.

@ceyusa ceyusa force-pushed the ceyusa:player-gl-context branch from de8b142 to 52f0bc6 Apr 21, 2019

@ceyusa

This comment has been minimized.

Copy link
Contributor Author

commented Apr 21, 2019

@ferjm r?

@ceyusa

This comment has been minimized.

Copy link
Contributor Author

commented Apr 21, 2019

this needs a modification in servo, since the player instantiation changed

@ferjm

ferjm approved these changes Apr 22, 2019

Copy link
Member

left a comment

Looks great. Thanks! r=me

//! for the GStreamer backend.
//!
//! The client application should implement this trait and pass the
//! trait object to its `player` intsance.

This comment has been minimized.

Copy link
@ferjm

ferjm Apr 22, 2019

Member

typo: instance

ceyusa and others added some commits Apr 21, 2019

Add trait PlayerGLContext
PlayerGLContext will provide the GL context paratemers required to
create a Render object. If those parameters are supported by the
Render, it will setup a GL rendering pipeline and will handle the
frames in form of GL Textures.

The PlayerGLContext is passed to the player at its instantiation.

@ferjm ferjm force-pushed the ceyusa:player-gl-context branch from 52f0bc6 to 16fdf92 Apr 30, 2019

@ferjm

This comment has been minimized.

Copy link
Member

commented Apr 30, 2019

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Apr 30, 2019

📌 Commit 16fdf92 has been approved by ferjm

bors-servo added a commit that referenced this pull request Apr 30, 2019

Auto merge of #241 - ceyusa:player-gl-context, r=ferjm
Add trait PlayerGLContext

PlayerGLContext will provide the GL context paratemers required to
create a Render object. If those parameters are supported by the
Render, it will setup a GL rendering pipeline and will handle the
frames in form of GL Textures.

The PlayerGLContext is passed to the player at its instantiation.
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Apr 30, 2019

⌛️ Testing commit 16fdf92 with merge 01cd9be...

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Apr 30, 2019

☀️ Test successful - checks-travis
Approved by: ferjm
Pushing 01cd9be to master...

@bors-servo bors-servo merged commit 16fdf92 into servo:master Apr 30, 2019

2 checks passed

Travis CI - Pull Request Build Passed
Details
homu Test successful
Details

@ceyusa ceyusa deleted the ceyusa:player-gl-context branch May 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.