Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd trait PlayerGLContext #241
Merged
Conversation
|
@ferjm r? |
|
this needs a modification in servo, since the player instantiation changed |
|
Looks great. Thanks! r=me |
player/context.rs
Outdated
| //! for the GStreamer backend. | ||
| //! | ||
| //! The client application should implement this trait and pass the | ||
| //! trait object to its `player` intsance. |
This comment has been minimized.
This comment has been minimized.
PlayerGLContext will provide the GL context paratemers required to create a Render object. If those parameters are supported by the Render, it will setup a GL rendering pipeline and will handle the frames in form of GL Textures. The PlayerGLContext is passed to the player at its instantiation.
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Apr 30, 2019
Add trait PlayerGLContext PlayerGLContext will provide the GL context paratemers required to create a Render object. If those parameters are supported by the Render, it will setup a GL rendering pipeline and will handle the frames in form of GL Textures. The PlayerGLContext is passed to the player at its instantiation.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
ceyusa commentedApr 21, 2019
PlayerGLContext will provide the GL context paratemers required to
create a Render object. If those parameters are supported by the
Render, it will setup a GL rendering pipeline and will handle the
frames in form of GL Textures.
The PlayerGLContext is passed to the player at its instantiation.