Oscillator node message

[PurpleHairEngineer]

Implemented an audio node message that is specific to OscillatorNode (using BiquadFilterNode as a model) which updates the node's oscillator type.

[PurpleHairEngineer]

I forgot to commit another relevant file. My bad.

[ferjm]

r=me with the comments applied, please.

Thanks!

[ferjm]

It would also be good to squash the commits before merging. Thanks

[PurpleHairEngineer]

@ferjm I made the changes you requested. However, I am not sure how to squash the commits before merging?

[ferjm]

Thanks @PurpleHairEngineer

To squash the commits:

• git rebase -i HEAD~3
• On the rebase interactive tool you'll see the 3 commits and a commented (#-prefixed lines) description of what you can do.
• In this case you want to add an s to the last 2 commits. Safe and exit.
• In the next screen you can change the commit message. Write something descriptive enough like 'Add OscillatorNode::SetOscillatorType message'. Safe and exit.

[PurpleHairEngineer]

@ferjm I followed your instructions to squash the commits and it gave me this message:

[detached HEAD d403149] Add OscillatorNode::SetOscillatorType message
Date: Sat Apr 27 10:41:05 2019 -0400
2 files changed, 18 insertions(+), 3 deletions(-)
Successfully rebased and updated refs/heads/OscillatorNodeMessage.

But I am not sure how to update this pull request to reflect the squashed commits.

I tried to do "git push -u origin OscillatorNodeMessage" as usual but it was rejected and said that the tip of my current branch is behind its remote counterpart.

[jdm]

@PurpleHairEngineer After modifying the branch history by squashing it, you need to force push (-f) to make the remote accept the new history.

[PurpleHairEngineer]

@jdm Thank you! That worked.

@ferjm Okay, I have successfully squashed the commits and updated this pull request. It still says 2 commits, but the first one is because I had to update our fork to reflect the change to a flat directory structure.

[ferjm]

That's ok. Thanks @PurpleHairEngineer :)

@bors-servo r+

[bors-servo]

📌 Commit d403149 has been approved by ferjm

[bors-servo]

⌛ Testing commit d403149 with merge 6e395ca...

[bors-servo]

☀️ Test successful - checks-travis
Approved by: ferjm
Pushing 6e395ca to master...