StereoPannerNode backend #243

PurpleHairEngineer · 2019-04-27T18:53:31Z

Implemented the backend for StereoPannerNode in the media crate by creating a new node implementation using PannerNode as a guide according to the specification.

Manishearth

I don't think this compiles yet?

This will also need an example, something similar to params.rs except you use a StereoPannerNode instead of a GainNode, and you only need to do a SetValue plus some linear ramps on the pan param.

(with headphones you should hear the sound moving around)

audio/stereo_panner_node.rs

PurpleHairEngineer · 2019-04-27T22:22:47Z

@Manishearth Okay, I updated stereo_panner_node.rs to reflect the changes you suggested. I will make another commit once I have made the example.

PurpleHairEngineer · 2019-04-28T19:09:20Z

@Manishearth Okay, I added an example. As I said to the dev-servo email list, I am still having trouble running any examples on my computer, so I am not able to test my example. But it seems to compile using "cargo build". Please let me know if I need to change anything else.

audio/stereo_panner_node.rs

examples/stereo_panner.rs

Manishearth

Your code still doesn't build, please ensure that cargo build passes.

Currently you don't have a module entry for your file, once you add that to lib.rs then Rust will find your code and be able to compile it.

audio/stereo_panner_node.rs

Manishearth

This still doesn't build, please ensure it builds first.

It's fine if you're still having trouble running it, but you shouldn't have any rust-side errors.

audio/stereo_panner.rs

examples/stereo_panner.rs

audio/stereo_panner.rs

Manishearth

Still doesn't build, commented with some obvious errors but I suspect there are more.

audio/stereo_panner.rs

PurpleHairEngineer · 2019-04-29T17:26:31Z

@Manishearth Thank you. I've just been committing incrementally as I've been fixing the problems you mention. I'm sorry if you get a notification every time. It seems to build now so please take a look.

Manishearth · 2019-04-29T17:35:13Z

Oh, I see, thanks. I'll review in a bit.

…

On Mon, Apr 29, 2019, 10:26 AM Maria Sable ***@***.***> wrote: @Manishearth <https://github.com/Manishearth> Thank you. I've just been committing incrementally as I've been fixing the problems you mention. I'm sorry if you get a notification every time. It seems to build now so please take a look. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#243 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAMK6SARKNRDYLAIBYRIIXTPS4VURANCNFSM4HI42HPA> .

Manishearth

Make sure you address the warnings as well.

audio/stereo_panner.rs

audio/node.rs

audio/stereo_panner.rs

PurpleHairEngineer · 2019-04-29T17:47:40Z

@Manishearth I made the changes you suggested, but it looks like all the current warnings are either because an import was never used or because a variable does not need to be mutable. It looks like a lot of the warnings are outside the scope of the files I've changed.

PurpleHairEngineer · 2019-04-30T00:24:46Z

@Manishearth It seems to build successfully now, and all the warnings are for files/parts unmodified by the committed code. Could you please take another look?

Manishearth

This works, thanks! Please run rustfmt on the files you added, and squash your commits. Let me know when you're done!

examples/stereo_panner.rs

PurpleHairEngineer · 2019-04-30T00:43:15Z

@Manishearth I am trying to squash my commits based on the instructions that were given in #242. However, when I run git rebase -i HEAD~15, I see a lot of additional commits from before I started committing (47 commands total). I am not sure how to handle this (what to do with them in the text editor).

Manishearth · 2019-04-30T00:45:50Z

It's because you merged master into this PR instead of rebasing over master. No big deal, I'll fix it.

PurpleHairEngineer · 2019-04-30T00:46:48Z

@Manishearth Sorry! So I should squash them all? Or just do nothing? I ran rustfmt on the modified files like you asked.

Manishearth · 2019-04-30T00:49:09Z

Actually it's just the first merge commit, remove everything before "Implemented the backend for StereoPannerNode" in the rebase dialog before using fixup on everything after that commit


        Implemented the backend for StereoPannerNode

PurpleHairEngineer · 2019-04-30T00:57:56Z

@Manishearth Okay, I did that. It stopped midway after I ran the fixup command and told me I had a merge conflict in Cargo.toml, which I thought I resolved. It seems to have squashed the commits, but now it says there are conflicts that must be resolved. I'm not sure how to fix this, since the Resolve Conflicts button is grayed out?

Manishearth · 2019-04-30T00:59:28Z

Can you tick the "allow collaborators to push to this pull request" checkbox on the side of this PR? I've got it rebased.

PurpleHairEngineer · 2019-04-30T01:00:32Z

@Manishearth The only checkbox I see is "Allow edits from maintainers", and it was already checked, but I just unchecked it and checked it again.

Manishearth · 2019-04-30T01:03:00Z

Ah, i had the fork wrong. Fixed.

Manishearth · 2019-04-30T01:03:25Z

@bors-servo r+

Thanks!

bors-servo · 2019-04-30T01:03:26Z

📌 Commit 6ba5507 has been approved by Manishearth

bors-servo · 2019-04-30T01:03:29Z

⌛ Testing commit 6ba5507 with merge 38a1f23...


        Auto merge of #243 - josephhutch:StereoPannerNodeMedia, r=Manishearth

StereoPannerNode backend Implemented the backend for StereoPannerNode in the media crate by creating a new node implementation using PannerNode as a guide according to the specification.

bors-servo · 2019-04-30T01:15:23Z

☀️ Test successful - checks-travis
Approved by: Manishearth
Pushing 38a1f23 to master...


        Auto merge of #23281 - josephhutch:StereoPannerNode, r=<try>

StereoPannerNode DOM  This is the DOM implementation for StereoPannerNode. Backend implemented in servo/media#243. ---  - [ ] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors - [ ] These changes fix #___ (GitHub issue number if applicable)  - [ ] There are tests for these changes OR - [ ] These changes do not require tests because ___    --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23281)


        Auto merge of #23281 - josephhutch:StereoPannerNode, r=Manishearth

StereoPannerNode DOM  This is the DOM implementation for StereoPannerNode. Backend implemented in servo/media#243. ---  - [ ] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors - [ ] These changes fix #___ (GitHub issue number if applicable)  - [ ] There are tests for these changes OR - [ ] These changes do not require tests because ___    --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23281)


        Auto merge of #23281 - josephhutch:StereoPannerNode, r=Manishearth

StereoPannerNode DOM  This is the DOM implementation for StereoPannerNode. Backend implemented in servo/media#243. ---  - [ ] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors - [ ] These changes fix #___ (GitHub issue number if applicable)  - [ ] There are tests for these changes OR - [ ] These changes do not require tests because ___    --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23281)


        Auto merge of #23281 - josephhutch:StereoPannerNode, r=Manishearth

StereoPannerNode DOM  This is the DOM implementation for StereoPannerNode. Backend implemented in servo/media#243. ---  - [ ] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors - [ ] These changes fix #___ (GitHub issue number if applicable)  - [ ] There are tests for these changes OR - [ ] These changes do not require tests because ___    --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23281)

PurpleHairEngineer changed the title ~~Implemented StereoPannerNode backend~~ StereoPannerNode backend Apr 27, 2019

PurpleHairEngineer mentioned this pull request Apr 27, 2019

StereoPannerNode DOM servo/servo#23281

Merged

0 of 5 tasks complete

Manishearth requested changes Apr 27, 2019

View changes

Manishearth reviewed Apr 28, 2019

View changes

audio/stereo_panner_node.rs Outdated Show resolved Hide resolved

audio/stereo_panner_node.rs Outdated Show resolved Hide resolved

Manishearth reviewed Apr 28, 2019

View changes

examples/stereo_panner.rs Show resolved Hide resolved

Manishearth reviewed Apr 28, 2019

View changes

audio/stereo_panner_node.rs Outdated Show resolved Hide resolved

Manishearth requested changes Apr 29, 2019

View changes

jdm reviewed Apr 29, 2019

View changes

audio/stereo_panner.rs Outdated Show resolved Hide resolved

Manishearth requested changes Apr 29, 2019

View changes

audio/stereo_panner.rs Show resolved Hide resolved

audio/stereo_panner.rs Outdated Show resolved Hide resolved

Manishearth requested changes Apr 29, 2019

View changes

audio/stereo_panner.rs Outdated Show resolved Hide resolved

audio/node.rs Show resolved Hide resolved

audio/stereo_panner.rs Outdated Show resolved Hide resolved

Manishearth approved these changes Apr 30, 2019

View changes

examples/stereo_panner.rs Show resolved Hide resolved

Implemented the backend for StereoPannerNode

Loading status checks…

6ba5507

bors-servo merged commit 6ba5507 into servo:master Apr 30, 2019
2 checks passed

2 checks passed

Travis CI - Pull Request Build Passed
Details

homu Test successful
Details

servo / media

StereoPannerNode backend #243

StereoPannerNode backend #243

PurpleHairEngineer commented Apr 27, 2019 •

edited

Manishearth left a comment

PurpleHairEngineer commented Apr 27, 2019

PurpleHairEngineer commented Apr 28, 2019 •

edited

Manishearth left a comment •

edited

Manishearth left a comment

Manishearth left a comment

PurpleHairEngineer commented Apr 29, 2019

Manishearth commented Apr 29, 2019

Manishearth left a comment

PurpleHairEngineer commented Apr 29, 2019 •

edited

PurpleHairEngineer commented Apr 30, 2019

Manishearth left a comment

PurpleHairEngineer commented Apr 30, 2019 •

edited

Manishearth commented Apr 30, 2019

PurpleHairEngineer commented Apr 30, 2019

Manishearth commented Apr 30, 2019

PurpleHairEngineer commented Apr 30, 2019 •

edited

Manishearth commented Apr 30, 2019

PurpleHairEngineer commented Apr 30, 2019 •

edited

Manishearth commented Apr 30, 2019

Manishearth commented Apr 30, 2019

bors-servo commented Apr 30, 2019

bors-servo commented Apr 30, 2019

bors-servo commented Apr 30, 2019

servo / media

Join GitHub today

StereoPannerNode backend #243

StereoPannerNode backend #243

Conversation

PurpleHairEngineer commented Apr 27, 2019 • edited

Manishearth left a comment

PurpleHairEngineer commented Apr 27, 2019

PurpleHairEngineer commented Apr 28, 2019 • edited

Manishearth left a comment • edited

Manishearth left a comment

Manishearth left a comment

PurpleHairEngineer commented Apr 29, 2019

Manishearth commented Apr 29, 2019

Manishearth left a comment

PurpleHairEngineer commented Apr 29, 2019 • edited

PurpleHairEngineer commented Apr 30, 2019

Manishearth left a comment

PurpleHairEngineer commented Apr 30, 2019 • edited

Manishearth commented Apr 30, 2019

PurpleHairEngineer commented Apr 30, 2019

Manishearth commented Apr 30, 2019

PurpleHairEngineer commented Apr 30, 2019 • edited

Manishearth commented Apr 30, 2019

PurpleHairEngineer commented Apr 30, 2019 • edited

Manishearth commented Apr 30, 2019

Manishearth commented Apr 30, 2019

bors-servo commented Apr 30, 2019

bors-servo commented Apr 30, 2019

bors-servo commented Apr 30, 2019

PurpleHairEngineer commented Apr 27, 2019 •

edited

PurpleHairEngineer commented Apr 28, 2019 •

edited

Manishearth left a comment •

edited

PurpleHairEngineer commented Apr 29, 2019 •

edited

PurpleHairEngineer commented Apr 30, 2019 •

edited

PurpleHairEngineer commented Apr 30, 2019 •

edited

PurpleHairEngineer commented Apr 30, 2019 •

edited