Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor clean ups #245

Merged
merged 2 commits into from May 6, 2019
Merged

Minor clean ups #245

merged 2 commits into from May 6, 2019

Conversation

@ceyusa
Copy link
Contributor

ceyusa commented May 3, 2019

[ ] remove spurious variable mutability labels
[ ] have just one PlayerGLContext implementation in player test app

ceyusa added 2 commits Apr 30, 2019
Now the Gl context implementation for Glutin handles if the user
request a non-GL rendering.
Latest rust and gstremaer-rs releases removed some mutability demands.
@ceyusa
Copy link
Contributor Author

ceyusa commented May 6, 2019

@jdm r?

@ferjm
Copy link
Member

ferjm commented May 6, 2019

@bors-servo
Copy link
Contributor

bors-servo commented May 6, 2019

📌 Commit e635566 has been approved by ferjm

@bors-servo
Copy link
Contributor

bors-servo commented May 6, 2019

Testing commit e635566 with merge 9bba7bd...

bors-servo added a commit that referenced this pull request May 6, 2019
Minor clean ups

[ ] remove spurious variable mutability labels
[ ] have just one PlayerGLContext implementation in player test app
@bors-servo
Copy link
Contributor

bors-servo commented May 6, 2019

☀️ Test successful - checks-travis
Approved by: ferjm
Pushing 9bba7bd to master...

@bors-servo bors-servo merged commit e635566 into servo:master May 6, 2019
2 checks passed
2 checks passed
Travis CI - Pull Request Build Passed
Details
homu Test successful
Details
@ceyusa ceyusa deleted the ceyusa:cleanups branch May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.