Skip to content

/ media

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DestinationNode placeholder #25

Merged
merged 1 commit into from May 23, 2018
Merged

DestinationNode placeholder #25

merged 1 commit into from May 23, 2018

Conversation

@ferjm
Copy link
Member

ferjm commented May 23, 2018

Fixes #24
@ferjm ferjm requested a review from Manishearth May 23, 2018
@ferjm
Copy link
Member Author

ferjm commented May 23, 2018

r? @Manishearth
@ferjm
DestinationNode placeholder
0a2945b
@ferjm ferjm force-pushed the ferjm:destinationnode branch from c6a0bcc to 0a2945b May 23, 2018
@Manishearth Manishearth merged commit 650a7dd into servo:master May 23, 2018
@Manishearth
Copy link
Member

Manishearth commented May 23, 2018

kinda feel like it shouldn't have an output at all, but having it in the graph and ensuring all sinks are destination node would work too.

(Also it lets us upmix/downmix with the same mechanism)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Manishearth Manishearth

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@ferjm @Manishearth
You can’t perform that action at this time.