Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upDon't reentrantly lock the stream id #250
Merged
Conversation
backends/gstreamer/webrtc.rs
Outdated
| .ok_or("Does not currently support non-gstreamer streams")?; | ||
| stream.insert_capsfilter(); | ||
| { | ||
| let stream = |
This comment has been minimized.
This comment has been minimized.
Manishearth
May 7, 2019
Author
Member
This does mean we end up locking twice. I could alternatively pass down the &mut GstreamerMediaStream to link_stream directly, but that gets uglier
|
The second commit is optional, it avoids double-locking but the code is a bit more complicated |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
May 7, 2019
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Manishearth commentedMay 7, 2019
fixes #249
r? @jdm or @ferjm