Skip to content

/ media

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow player example to build on macOS. #253

Closed
wants to merge 1 commit into from
Closed

Allow player example to build on macOS. #253

wants to merge 1 commit into from

Conversation

@jdm
Copy link
Member

jdm commented May 7, 2019 •
edited

Fixes #251.
@jdm
Allow player example to build on macOS.
Loading status checks…
3f5c40b
@Manishearth
Copy link
Member

Manishearth commented May 7, 2019

Comments on why this is safe?
@ceyusa
Copy link
Contributor

ceyusa commented May 7, 2019

In servo we'll meet with the same issue. And I'm not sure if that trait must me sendable.

ceyusa@acff252
@ceyusa ceyusa mentioned this pull request May 9, 2019
Merged
bors-servo added a commit that referenced this pull request May 10, 2019
@bors-servo
Auto merge of #255 - ceyusa:trait-no-send, r=ferjm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
121f943 
PlayerGLContext does not need to be thread aware

Fixes: #251

As far as I have played, there's no need to make PlayerGLContext trait thread aware, so we could avoid the changes in #253
@ferjm
Copy link
Member

ferjm commented May 10, 2019

#255 fixes this. Thanks!
@ferjm ferjm closed this May 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Build broken on Mac
4 participants
@jdm @Manishearth @ceyusa @ferjm
You can’t perform that action at this time.