Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upSet up very basic messaging #26
Merged
Conversation
|
tbh I was hoping to have a nicer API. Something like: let node: Box<OscillatorNode> = graph.get_node(0);
node.set_frequency(220.);But I didn't thought too much about it, so let's merge this to unblock the dependent work. We can revisit this later. |
| @@ -13,7 +13,10 @@ fn main() { | |||
| options.gain = 0.5; | |||
| graph.create_node(AudioNodeType::GainNode(options)); | |||
| graph.resume_processing(); | |||
| thread::sleep(time::Duration::from_millis(5000)); | |||
| thread::sleep(time::Duration::from_millis(2000)); | |||
This comment has been minimized.
This comment has been minimized.
| @@ -13,7 +13,10 @@ fn main() { | |||
| options.gain = 0.5; | |||
| graph.create_node(AudioNodeType::GainNode(options)); | |||
| graph.resume_processing(); | |||
| thread::sleep(time::Duration::from_millis(5000)); | |||
| thread::sleep(time::Duration::from_millis(2000)); | |||
| graph.message_node(0, AudioNodeMessage::SetFloatParam(220.)); | |||
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Manishearth
force-pushed the
messaging
branch
2 times, most recently
from
ab8d004
to
55d1728
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Manishearth commentedMay 23, 2018
SetFloatParam is a dummy message, but the idea is to have this framework in place so that if I start working on AudioParams it won't clash with SchedulerNode work.
r? @ferjm