Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGet rid of unsafe SDP media workaround #273
Merged
Conversation
|
I guess you can also remove from |
|
Good catch |
|
On 26 June 2019 19:08:54 EEST, Manish Goregaokar ***@***.***> wrote:
Upstream had [a
bug](https://gitlab.freedesktop.org/gstreamer/gstreamer-rs/issues/189)
which we worked around in #213 by
directly accessing the underlying GObject data. This is no longer
necessary after the gstreamer update, pulling in
#213
r? @sdroege @ferjm
You can view, comment on, or merge this pull request online at:
#273
-- Commit Summary --
* Get rid of unsafe SDP media workaround
-- File Changes --
M backends/gstreamer/webrtc.rs (13)
-- Patch Links --
https://github.com/servo/media/pull/273.patch
https://github.com/servo/media/pull/273.diff
There's also an iterator for the medias of the message now. That should simplify the code a bit more :)
…--
Sent from my Android device with K-9 Mail. Please excuse my brevity.
|
|
Done! |
|
lgtm ! :) @bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Jun 26, 2019
Get rid of unsafe SDP media workaround Upstream had [a bug](https://gitlab.freedesktop.org/gstreamer/gstreamer-rs/issues/189) which we worked around in #213 by directly accessing the underlying GObject data. This is no longer necessary after the gstreamer update, pulling in #213 r? @sdroege @ferjm
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Manishearth commentedJun 26, 2019
Upstream had a bug which we worked around in #213 by directly accessing the underlying GObject data. This is no longer necessary after the gstreamer update, pulling in #213
r? @sdroege @ferjm