Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upShutdown audio contexts and players in all the examples #275
Conversation
|
r? @ceyusa |
|
lgtm @bors-servo r+ |
|
Out of curiosity, what is the current behaviour without these changes? |
AFAIK the media elements in the examples are not removed from the global hashmaps. |
|
Why not have a destructor on the context handle that sends a shutdown message on death? |
Essentially that. Although these are weak references to the media elements. And they may be removed on following mutes/unmutes.
Could you elaborate on this, please? We can improve this by making the Player/AudioContext send such a message to the owner GStreamerBackend on drop. I am not sure if that's what you meant. |
|
Just to clarify, the Backend, once instantiated, it is kept alive until the browser shutdowns, then we should remove the media elements when they are removed of the webpage while the browser keeps running. |
|
bors-servo ignores me :( Well, perhaps it is better to clarify these questions before merging :) |
|
Closing in favour of #279 |
ferjm commentedJul 5, 2019
No description provided.