WaveShaper node implementation without oversampling #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
im not sure about this part of the spec, specifically whether curve attr can be set exactly once per node lifetime or it can be set/unset multiple times right now (in this PR) it is implemented so it can be set exactly once and then it |
khodzha
force-pushed
the
master
branch
2 times, most recently
from
3b1f3de
to
24df6fd
Compare
ferjm
approved these changes
Jul 9, 2019
|
Thanks! @bors-servo r+ |
|
📌 Commit 1a4ddda has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Jul 10, 2019
WaveShaper node implementation without oversampling Issue at hand: #205
|
☀️ Test successful - checks-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue at hand: #205