Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upWaveShaper node implementation without oversampling #276
Conversation
|
im not sure about this part of the spec, specifically whether curve attr can be set exactly once per node lifetime or it can be set/unset multiple times right now (in this PR) it is implemented so it can be set exactly once and then it |
khodzha
force-pushed the
khodzha:master
branch
2 times, most recently
from
3b1f3de
to
24df6fd
|
LGTM with the nits addressed. Thanks! |
|
Thanks! @bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Jul 10, 2019
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
khodzha commentedJul 5, 2019
Issue at hand: #205