Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRemove shutdown_player and shutdown_audio_context #279
+120
−109
Conversation
|
r? @Manishearth |
|
|
ferjm
force-pushed the
ferjm:muteables.shutdown
branch
2 times, most recently
from
e334613
to
77a42b4
|
|
|
r? @ceyusa |
| } | ||
| } | ||
| }; | ||
| }) |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ferjm
Aug 14, 2019
Author
Member
The thread dies as soon as it processes the BackendMsg::Shutdown channel message.
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Aug 14, 2019
Remove shutdown_player and shutdown_audio_context This is a cleaner approach that does not require consumers of the API to call any shutdown* method to ensure that the Muteables are removed appropriately.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
ferjm commentedJul 8, 2019
This is a cleaner approach that does not require consumers of the API to call any shutdown* method to ensure that the Muteables are removed appropriately.