Remove shutdown_player and shutdown_audio_context#279
Merged
bors-servo merged 3 commits intoservo:masterfrom Aug 14, 2019
Merged
Remove shutdown_player and shutdown_audio_context#279bors-servo merged 3 commits intoservo:masterfrom
bors-servo merged 3 commits intoservo:masterfrom
Conversation
Contributor
Author
|
r? @Manishearth |
Contributor
|
☔ The latest upstream changes (presumably #281) made this pull request unmergeable. Please resolve the merge conflicts. |
ferjm
force-pushed
the
muteables.shutdown
branch
2 times, most recently
from
e334613 to
77a42b4
Compare
Contributor
|
☔ The latest upstream changes (presumably #285) made this pull request unmergeable. Please resolve the merge conflicts. |
ferjm
force-pushed
the
muteables.shutdown
branch
from
77a42b4 to
b1ae3b3
Compare
Contributor
Author
|
r? @ceyusa |
ceyusa
reviewed
Aug 13, 2019
| } | ||
| } | ||
| }; | ||
| }) |
Contributor
There was a problem hiding this comment.
how do we stop this thread?
Contributor
Author
There was a problem hiding this comment.
The thread dies as soon as it processes the BackendMsg::Shutdown channel message.
Contributor
|
@bors-servo r+ |
Contributor
|
📌 Commit b1ae3b3 has been approved by |
Contributor
bors-servo
pushed a commit
that referenced
this pull request
Aug 14, 2019
Remove shutdown_player and shutdown_audio_context This is a cleaner approach that does not require consumers of the API to call any shutdown* method to ensure that the Muteables are removed appropriately.
Contributor
|
☀️ Test successful - checks-travis |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a cleaner approach that does not require consumers of the API to call any shutdown* method to ensure that the Muteables are removed appropriately.