Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove shutdown_player and shutdown_audio_context #279

Merged
merged 3 commits into from Aug 14, 2019

Conversation

@ferjm
Copy link
Member

ferjm commented Jul 8, 2019

This is a cleaner approach that does not require consumers of the API to call any shutdown* method to ensure that the Muteables are removed appropriately.

@ferjm
Copy link
Member Author

ferjm commented Jul 8, 2019

@ferjm ferjm force-pushed the ferjm:muteables.shutdown branch from 00913e6 to 8b95ba5 Jul 8, 2019
@bors-servo
Copy link
Contributor

bors-servo commented Jul 10, 2019

The latest upstream changes (presumably #281) made this pull request unmergeable. Please resolve the merge conflicts.

@ferjm ferjm force-pushed the ferjm:muteables.shutdown branch 2 times, most recently from e334613 to 77a42b4 Jul 12, 2019
@bors-servo
Copy link
Contributor

bors-servo commented Jul 18, 2019

The latest upstream changes (presumably #285) made this pull request unmergeable. Please resolve the merge conflicts.

@ferjm ferjm force-pushed the ferjm:muteables.shutdown branch from 77a42b4 to b1ae3b3 Aug 13, 2019
@ferjm
Copy link
Member Author

ferjm commented Aug 13, 2019

r? @ceyusa

}
}
};
})

This comment has been minimized.

@ceyusa

ceyusa Aug 13, 2019

Contributor

how do we stop this thread?

This comment has been minimized.

@ferjm

ferjm Aug 14, 2019

Author Member

The thread dies as soon as it processes the BackendMsg::Shutdown channel message.

@ceyusa
Copy link
Contributor

ceyusa commented Aug 14, 2019

@bors-servo
Copy link
Contributor

bors-servo commented Aug 14, 2019

📌 Commit b1ae3b3 has been approved by ceyusa

@bors-servo
Copy link
Contributor

bors-servo commented Aug 14, 2019

Testing commit b1ae3b3 with merge a70f024...

bors-servo added a commit that referenced this pull request Aug 14, 2019
Remove shutdown_player and shutdown_audio_context

This is a cleaner approach that does not require consumers of the API to call any shutdown* method to ensure that the Muteables are removed appropriately.
@bors-servo
Copy link
Contributor

bors-servo commented Aug 14, 2019

☀️ Test successful - checks-travis
Approved by: ceyusa
Pushing a70f024 to master...

@bors-servo bors-servo merged commit b1ae3b3 into servo:master Aug 14, 2019
2 checks passed
2 checks passed
Travis CI - Pull Request Build Passed
Details
homu Test successful
Details
@ferjm ferjm deleted the ferjm:muteables.shutdown branch Aug 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.