Skip to content

/ media

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite player sample app #285

Merged
merged 5 commits into from Jul 18, 2019
Merged

Rewrite player sample app #285

merged 5 commits into from Jul 18, 2019
+1,107 −970

Conversation

@ceyusa
Copy link
Contributor

ceyusa commented Jul 17, 2019

With this complete rewrite of the player sample app now

  • upgraded glutin and webrender dependencies
  • can render the WR stats
  • fixes a huge mem leak when rendering textures
  • do forward and backward seeks with left/right keys
  • pause with the spacebar
  • it simplifies the WR logic, removing the usage of the wr test app skeleton
  • and overall, it mimics the same logic that is implemented in servo
ceyusa added 5 commits Jul 11, 2019
@ceyusa
Apply rustfmt and remove unused module
aeb2a2b
@ceyusa
Move up Servo/Media init
02d046e
@ceyusa
render-unix: handle contexts with Wayland and X11/GLX displays
990a7cc
@ceyusa
clap dependency is only used for non android
a2c1246
@ceyusa
Major rewrite of player sample
Loading status checks…
2556fb7 
Among other things, this rewrite includes:

+ Upgrade glutin and webrender
+ Mimics the current logic used in servo
@ceyusa ceyusa force-pushed the ceyusa:new-player branch from fbf2c07 to 2556fb7 Jul 17, 2019
@ferjm ferjm changed the title [WIP] rewrite player sample app Rewrite player sample app Jul 18, 2019
@ferjm
ferjm approved these changes Jul 18, 2019
View changes
Copy link
Member

ferjm left a comment

Thanks!
@ferjm
Copy link
Member

ferjm commented Jul 18, 2019

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Jul 18, 2019

📌 Commit 2556fb7 has been approved by ferjm
bors-servo added a commit that referenced this pull request Jul 18, 2019
@bors-servo
Auto merge of #285 - ceyusa:new-player, r=ferjm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
0927324 
Rewrite player sample app

With this complete rewrite of the player sample app now

+ upgraded glutin and webrender dependencies
+ can render the WR stats
+ fixes a huge mem leak when rendering textures
+ do forward and backward seeks with left/right keys
+ pause with the spacebar
+ it simplifies the WR logic, removing the usage of the wr test app skeleton
+ and overall, it mimics the same logic that is implemented in servo
@bors-servo
Copy link
Contributor

bors-servo commented Jul 18, 2019

⌛ Testing commit 2556fb7 with merge 0927324...
@bors-servo
Copy link
Contributor

bors-servo commented Jul 18, 2019

☀️ Test successful - checks-travis
Approved by: ferjm
Pushing 0927324 to master...
@bors-servo bors-servo merged commit 2556fb7 into servo:master Jul 18, 2019
2 checks passed
2 checks passed
Travis CI - Pull Request Build Passed
Details
homu Test successful
Details
This was referenced Jul 18, 2019
Closed
Merged
@ceyusa ceyusa deleted the ceyusa:new-player branch Jul 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ferjm ferjm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@ceyusa @ferjm @bors-servo
You can’t perform that action at this time.