Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd feature handling #290
Merged
Add feature handling #290
Conversation
|
@ferjm what do you think about this approach? |
|
Redirecting to @Manishearth since ferjm is on vacation. |
|
I like the idea. I don't think it's super necessary and it may be additional friction when working on it, but overall should be a plus. Make sure you update Servo to enable the various features. @bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Jul 30, 2019
Add feature handling These two patches add * Split the different dependencies for samples, keeping a control of which dependencies are required by which examples. * Added a GL winsys feature, for unix render, so it can modified for different CI
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
ceyusa commentedJul 29, 2019
These two patches add