Fix Android audio stream demo #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The remaining issue to fix is that the AudioStream seems to be garbage-collected too fast, so it should be stored somehow into a JNI env object field.
|
r? @philn |
|
The src_element URIHandler support is still good to have/keep because it would make possible multi-simultaneous audio_stream playback |
philn
approved these changes
May 4, 2018
| .set_property("uri", &glib::Value::from("webaudiosrc://foo")) | ||
| .expect("Cant't set URI property"); | ||
| Ok(Self { player: player }) | ||
| if let Some(category) = gst::DebugCategory::get("gst-player") { |
There was a problem hiding this comment.
This is useless now, sorry I missed it in the previous patch :) Anyway just a nit
Manishearth
pushed a commit
to Manishearth/media
that referenced
this pull request
Jan 25, 2019
Move offer flow to API user
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.