Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upHandling external OES textures #303
Merged
Conversation
Since the sample is not used after the frame instantiation, it is better to transfer the ownership to the frame builder.
Instead of passing the buffer and the video info, pass the whole sample, because the implementator of build_frame() could use the caps information.
|
@bors-servo r+ |
|
@bors-servo r=ferjm |
|
|
bors-servo
added a commit
that referenced
this pull request
Aug 29, 2019
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
ceyusa commentedAug 29, 2019
Fix #291