Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated player for setting audio and video tracks #305

Merged
merged 1 commit into from Sep 11, 2019

Conversation

@sreeise
Copy link
Contributor

sreeise commented Sep 11, 2019

This pull request is for being able to set video and audio tracks and is part of Servo issue 22799.

Servo should be able to set multiple audio tracks at one time but the work here only allows for one. If anyone has any advice on how to set multiple audio tracks that would be great!

@ferjm
ferjm approved these changes Sep 11, 2019
Copy link
Member

ferjm left a comment

Thanks @sreeise !

Unfortunately, there is currently no way to set and play multiple audio streams with GstPlayer, so we are limited to a single audio track for now.

@ferjm
Copy link
Member

ferjm commented Sep 11, 2019

@bors-servo
Copy link
Contributor

bors-servo commented Sep 11, 2019

📌 Commit 8c8103b has been approved by ferjm

@bors-servo
Copy link
Contributor

bors-servo commented Sep 11, 2019

Testing commit 8c8103b with merge f9aed4e...

bors-servo added a commit that referenced this pull request Sep 11, 2019
Updated player for setting audio and video tracks

This pull request is for being able to set video and audio tracks and is part of Servo issue [22799](servo/servo#22799).

Servo should be able to set multiple audio tracks at one time but the work here only allows for one. If anyone has any advice on how to set multiple audio tracks that would be great!
@bors-servo
Copy link
Contributor

bors-servo commented Sep 11, 2019

☀️ Test successful - checks-travis
Approved by: ferjm
Pushing f9aed4e to master...

@bors-servo bors-servo merged commit 8c8103b into servo:master Sep 11, 2019
3 checks passed
3 checks passed
Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
@ferjm
Copy link
Member

ferjm commented Sep 12, 2019

There's previous work done to play multiple audio tracks simultaneously with audiomixer.

https://mozilla.logbot.info/servo-media/20190911#c16606524-c16606984

@sreeise
Copy link
Contributor Author

sreeise commented Sep 16, 2019

There's previous work done to play multiple audio tracks simultaneously with audiomixer.

https://mozilla.logbot.info/servo-media/20190911#c16606524-c16606984

Ahh interesting. I am not too familiar with how the GStreamer plugins are done in servo media and I am assuming audiomixer is a plugin here. Could you point me in the general direction of where this is done or how it could be done in servo media if you don't mind?

@jdm
Copy link
Member

jdm commented Sep 16, 2019

https://coaxion.net/blog/2013/11/synchronized-audio-mixing-in-gstreamer/ has a little bit of information about the audiomixer plugin and how it can fit into a gstreamer audio pipeline.

@sreeise sreeise deleted the sreeise:set_audio_video_tracks branch Sep 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.