Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRender android #308
Merged
Render android #308
Conversation
Since they are already especified when loaded by platform in the GStreamerRender object.
ceyusa
force-pushed the
ceyusa:render-android
branch
6 times, most recently
from
5bab635
to
3047ced
|
Sadly, we don't have a test for android rendering gl textures. We need to test it in Servo directly. |
|
I'll test it with Servo as soon as possible |
|
removed the GL context activation |
|
Can we merge this for now? @ferjm, @asajeffrey ? |
|
Yes, I think we can merge as soon as CI is happy. |
|
Fine by me. it would be nice if we could figure out a way to use features rather than gating on |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Sep 16, 2019
Render android Add GL render for android target, which is a unix type with only EGL.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
ceyusa commentedSep 12, 2019
Add GL render for android target, which is a unix type with only EGL.