Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove --all-features #320

Closed
wants to merge 1 commit into from
Closed

Conversation

@Manishearth
Copy link
Member

Manishearth commented Oct 18, 2019

Fixes the build

This was broken by rust-lang/cargo#7507 , but the previous behavior was that the flags were ignored, so I removed them

r? nox @ferjm

@nox
Copy link
Member

nox commented Oct 18, 2019

@bors-servo
Copy link
Contributor

bors-servo commented Oct 18, 2019

📌 Commit 740551a has been approved by nox

bors-servo added a commit that referenced this pull request Oct 18, 2019
Remove --all-features

Fixes the build

This was broken by rust-lang/cargo#7507 , but the previous behavior was that the flags were ignored, so I removed them

r? nox @ferjm
@bors-servo
Copy link
Contributor

bors-servo commented Oct 18, 2019

Testing commit 740551a with merge 3f89925...

@bors-servo
Copy link
Contributor

bors-servo commented Oct 18, 2019

💔 Test failed - checks-travis

@CYBAI
Copy link

CYBAI commented Oct 18, 2019

error: target `play_media_stream` in package `examples` requires the features: `player`

Consider enabling them by passing, e.g., `--features="player"`

error: target `play_noise` in package `examples` requires the features: `noise`

Consider enabling them by passing, e.g., `--features="noise"`

error: target `simple_player` in package `examples` requires the features: `player`

Consider enabling them by passing, e.g., `--features="player"`

error: target `simple_webrtc` in package `examples` requires the features: `webrtc`

Consider enabling them by passing, e.g., `--features="webrtc"`
@Manishearth Manishearth force-pushed the Manishearth:all-features branch from 740551a to a9d9a5e Oct 18, 2019
@Manishearth
Copy link
Member Author

Manishearth commented Oct 18, 2019

@bors-servo r=nox

trying explicit features

@bors-servo
Copy link
Contributor

bors-servo commented Oct 18, 2019

📌 Commit a9d9a5e has been approved by nox

@bors-servo
Copy link
Contributor

bors-servo commented Oct 18, 2019

Testing commit a9d9a5e with merge 09eefc6...

bors-servo added a commit that referenced this pull request Oct 18, 2019
Remove --all-features

Fixes the build

This was broken by rust-lang/cargo#7507 , but the previous behavior was that the flags were ignored, so I removed them

r? nox @ferjm
@bors-servo
Copy link
Contributor

bors-servo commented Oct 18, 2019

💔 Test failed - checks-travis

@Manishearth
Copy link
Member Author

Manishearth commented Oct 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.