Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign uplinear extrapolation of endpoint samples in AudioBufferSourceNode #331
Conversation
|
cc @ferjm |
|
Can you also fix the warning that's failing appveyor? |
|
should i squash these commits? |
|
@bors-servo r+ nah, they do different things and apply independently Thanks! |
|
|
bors-servo
added a commit
that referenced
this pull request
Jan 28, 2020
linear extrapolation of endpoint samples in AudioBufferSourceNode issue #300 running test https://github.com/servo/servo/blob/master/tests/wpt/web-platform-tests/webaudio/the-audio-api/the-audiobuffersourcenode-interface/buffer-resampling.html after this patch results in: 
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
khodzha commentedJan 27, 2020
issue #300
running test https://github.com/servo/servo/blob/master/tests/wpt/web-platform-tests/webaudio/the-audio-api/the-audiobuffersourcenode-interface/buffer-resampling.html after this patch results in:
