Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

return err if ServoMedia wasnt initialized #335

Merged
merged 3 commits into from Apr 20, 2020
Merged

return err if ServoMedia wasnt initialized #335

merged 3 commits into from Apr 20, 2020

Conversation

khodzha
Copy link
Contributor

@khodzha khodzha commented Apr 13, 2020 •
edited

im not sure how to do this with lazy_static since init requires type parameter
but at least this addresses null pointer dereference

issue at hand: #306

Manishearth
Manishearth approved these changes Apr 13, 2020
View reviewed changes
Copy link
Member

@Manishearth Manishearth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r? @nox

@Manishearth Manishearth merged commit 62cd58a into servo:master Apr 20, 2020
@Manishearth
Copy link
Member

Thanks!

@Manishearth Manishearth mentioned this pull request Apr 20, 2020
Closed
@khodzha khodzha deleted the 323 branch April 20, 2020 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Manishearth Manishearth Manishearth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@khodzha @Manishearth