Skip to content

/ media

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return err if ServoMedia wasnt initialized #335

Merged
merged 3 commits into from Apr 20, 2020
Merged

return err if ServoMedia wasnt initialized #335

merged 3 commits into from Apr 20, 2020

Conversation

@khodzha
Copy link
Contributor

khodzha commented Apr 13, 2020 •
edited

im not sure how to do this with lazy_static since init requires type parameter
but at least this addresses null pointer dereference

issue at hand: #306
@khodzha
return err if ServoMedia wasnt initialized
Loading status checks…
1a81e6e
@Manishearth
Manishearth approved these changes Apr 13, 2020
View changes
Copy link
Member

Manishearth left a comment

r? @nox
khodzha added 2 commits Apr 13, 2020
@khodzha
removed braces to avoid -D unused-braces failing build
Loading status checks…
cc9fb62
@khodzha
removed doc comments on macro invocations
Loading status checks…
9c76811
@Manishearth Manishearth merged commit 62cd58a into servo:master Apr 20, 2020
2 checks passed
2 checks passed
Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@Manishearth
Copy link
Member

Manishearth commented Apr 20, 2020

Thanks!
@Manishearth Manishearth mentioned this pull request Apr 20, 2020
Closed
@khodzha khodzha deleted the khodzha:323 branch Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Manishearth Manishearth

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@khodzha @Manishearth
You can’t perform that action at this time.