Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upDatachannels follow-up fixes #353
Merged
Conversation
|
Ugh... this requires upgrading the gstreamer binaries for Travis |
backends/gstreamer/datachannel.rs
Outdated
| } | ||
|
|
||
| if let Some(channel_id) = init.id { | ||
| init_struct.set_value("id", (channel_id as u32).to_send_value()); |
This comment has been minimized.
This comment has been minimized.
Manishearth
Jun 10, 2020
Member
can we call this something like servo-id to prevent any future clash
This comment has been minimized.
This comment has been minimized.
ferjm
Jun 11, 2020
Author
Member
This is actually the GstWebRTCDataChannel.id param that matches the RTCDataChannel.id spec one. So I think we shouldn't change the naming here. I can change the one for the internal data channel id though.
This comment has been minimized.
This comment has been minimized.
|
Given that we don't support Android in Servo anymore, I have disabled the Android build in Travis. |
|
r=me whenever ready |
|
@bors-servo r=Manishearth |
|
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
ferjm commentedJun 10, 2020
With this fixes we get closer to be spec compliant