Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upDevice monitor #368
Merged
Device monitor #368
Conversation
backends/gstreamer/lib.rs
Outdated
| @@ -1,4 +1,6 @@ | |||
| #![feature(nll)] | |||
|
|
|||
| extern crate atomic_refcell; | |||
This comment has been minimized.
This comment has been minimized.
| impl MediaDeviceMonitor for GStreamerDeviceMonitor { | ||
| fn enumerate_devices(&self) -> Result<Vec<MediaDeviceInfo>, ()> { | ||
| { | ||
| if let Some(ref devices) = *self.devices.borrow() { |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Manishearth
Jul 8, 2020
Member
though it's not that important, actually, sicne we don't use this cache in servo
|
r=me |
|
@bors-servo r=Manishearth |
|
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
ferjm commentedJul 2, 2020
•
edited
This is required for https://github.com/servo/servo/pull/27152/files