Move audio sink into audio destination node #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Manishearth |
Manishearth
approved these changes
Jun 4, 2018
Closed
ferjm
force-pushed
the
destinationnode.sink
branch
from
c5d749e
to
7f63337
Compare
|
I ended up storing the destination node separated from the graph. I think it'll be slightly simpler this way. Once we add graph support, we can simply store the indexes that are connected to the destination node input. |
Manishearth
reviewed
Jun 7, 2018
| } | ||
| } | ||
|
|
||
| impl AudioNodeEngine for DestinationNode { | ||
| fn process(&mut self, inputs: Chunk, _: &BlockInfo) -> Chunk { | ||
| inputs | ||
| fn process(&mut self, inputs: Chunk, _: &BlockInfo) -> Option<Chunk> { |
There was a problem hiding this comment.
I don't think we need to return Option here, Chunk::default is empty. Chunk contains the number of blocks equal to the number of output ports, here zero.
Also, can we switch back to the old sink model? My graph PR needs it to work since there's some extra work that may need to be done in between.
There was a problem hiding this comment.
Ok. Since the PR was approved and you didn't comment any further, I assumed you were ok with merging this. I'll revert it.
|
Yeah I just forgot to comment, that was my bad 😅😅
…On Thu, Jun 7, 2018, 5:53 AM Fernando Jiménez Moreno < ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/audio/destination_node.rs
<#38 (comment)>:
> }
}
impl AudioNodeEngine for DestinationNode {
- fn process(&mut self, inputs: Chunk, _: &BlockInfo) -> Chunk {
- inputs
+ fn process(&mut self, inputs: Chunk, _: &BlockInfo) -> Option<Chunk> {
Ok. Since the PR was approved and you didn't comment any further, I
assumed you were ok with merging this. I'll revert it.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#38 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABivSNqVllO3GcjzD5PBbnwmPUc-3ip9ks5t6SJlgaJpZM4UZVUr>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.