Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upBasic graph abstraction #45
Conversation
|
Can be merged as-is, opening it early so I can get feedback on the design before i integrate it with everything else. |
|
Looks good so far! Great work as usual :) I have a couple of questions:
|
| self.dest_id | ||
| } | ||
|
|
||
| pub fn process(&mut self, info: &BlockInfo) -> Chunk { |
This comment has been minimized.
This comment has been minimized.
| } | ||
|
|
||
| pub struct Node { | ||
| node: RefCell<Box<AudioNodeEngine>>, |
This comment has been minimized.
This comment has been minimized.
| fn output_count(&self) -> u32 { 1 } | ||
|
|
||
| /// If we're the destination node, extract the contained data | ||
| fn destination_data(&mut self) -> Option<Chunk> { None } |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Manishearth
Jun 7, 2018
•
Author
Member
How? BlockInfo is immutable (and not worth a refcell IMO)
I don't want to do the model of the destination node pushing directly to the sink because the spec represents this as a separate "record the input for future retrieval" step. But we can still do that for now if you think it's better.
This comment has been minimized.
This comment has been minimized.
|
For cycles: we can do the traversal a little bit more manually to support it, the algorithm isn't too hard. I was thinking once this is implemented we can parallelize out that work to support all the little graph things. |
|
For AudioParams the plan was to allow for params to "create" new input ports. We can have an additional boolean flag on PortId, and when flipped it enumerates params instead. |
|
I am going to go ahead and merge this as-is, as I am moving lots of code for the AudioBufferSourceNode work and this will likely cause conflicts. |
|
Sounds good. I'll do all the fixups when I get back from this hike.
…On Thu, Jun 7, 2018, 6:21 AM Fernando Jiménez Moreno < ***@***.***> wrote:
I am going to go ahead and merge this as-is, as I am moving lots of code
for the AudioBufferSourceNode work and this will likely cause conflicts.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#45 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABivSIcT4c0Q9S_WmICzyLXgMTCdjuvRks5t6SjFgaJpZM4UdeuW>
.
|
Manishearth commentedJun 6, 2018
Todo: Using it in the code
r? @ferjm