Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upBasic AudioBufferSourceNode implementation #46
Merged
+477
−212
Conversation
src/audio/buffer_source_node.rs
Outdated
| { | ||
| let data = inputs.blocks[0].data_mut(); | ||
|
|
||
| for sample in data.iter_mut() { |
This comment has been minimized.
This comment has been minimized.
Manishearth
Jun 7, 2018
Member
We can just do a memcpy here I think?
https://doc.rust-lang.org/nightly/std/primitive.slice.html#method.copy_from_slice
|
I'm going to merge early so that we don't have too many conflicts, please look into the loop copy issue when you have time |
This was referenced Jun 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
ferjm commentedJun 7, 2018
There are still several things to do for this node type but I thought I should push this as soon as possible as it is moving lots of code around.