Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upMinor decoder fixes #53
Merged
+34
−10
Conversation
| ("format", &gst_audio::AUDIO_FORMAT_F32.to_string()), | ||
| ("layout", &"interleaved"), | ||
| ("channels", &(options.channels as i32)), | ||
| ("rate", &(options.sample_rate as i32)), |
This comment has been minimized.
This comment has been minimized.
sdroege
Jun 20, 2018
Contributor
Well if you only want to handle one specific number of channels/rate here you can and probably should continue using AudioInfo. The full caps API is only needed here if you want to support e.g. ranges of channels (say, 1-16 channels) or rates
|
r? @Manishearth |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
ferjm commentedJun 20, 2018
Addressing this review feedback #52 (comment)