Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd basic channels abstraction, ChannelMergerNode, and sink support for channels #54
+293
−29
Conversation
|
We can land this now before everything else is in place just to make things easier |
Manishearth
changed the title
|
Scratch that, I planned ahead pretty well and the actual stuff was easy to implement with this abstraction in place. https://twitter.com/ManishEarth/status/1002328167816630272?s=19 strikes again |
|
Nice! LGTM |
| use servo_media::audio::gain_node::GainNodeOptions; | ||
| use servo_media::audio::node::{AudioNodeMessage, AudioNodeType}; | ||
| use servo_media::audio::oscillator_node::OscillatorNodeMessage; | ||
| use servo_media::audio::param::UserAutomationEvent; |
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Manishearth commentedJun 21, 2018
•
edited
Channels are stored as a continuous buffer with each FRAMES_PER_BLOCK chunk being one channel. They can also be grouped together via
repeat-- e.g. if an oscillator node produces 2 channels of output, it will actually produce one channel with arepeatbit set. Similarly, one-channel blocks will be upmixed to 2-channelrepeatblocks.The iterator is a bit awkward due to the lack of associated type constructors (it's a streaming iterator).
part of #18