Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upSome graph API changes #56
Merged
+323
−213
Conversation
|
r? @Manishearth |
| // XXX Get this from AudioContextOptions. | ||
| let sample_rate = 44100.; | ||
| /// Constructs a new audio context. | ||
| pub fn new(options: Option<AudioGraphOptions>) -> Self { |
This comment has been minimized.
This comment has been minimized.
Manishearth
Jun 22, 2018
Member
I think just having an AudioGraphOptions argument here and asking people to pass Default is fine. Either way works.
|
Yeah naming it to context is fine. That way we can call GraphImpl AudioGraph |
|
merging, fix the options and context thing if you want |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
ferjm commentedJun 22, 2018
I identified these needs while working on the DOM bindings.
I am tempted to rename AudioGraph to AudioContext everywhere. wdyt?