Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upChannel fixes #58
Merged
Channel fixes #58
+295
−8
Conversation
| @@ -124,7 +124,7 @@ impl AudioSink for GStreamerAudioSink { | |||
| // sometimes nothing reaches the output | |||
| if chunk.len() == 0 { | |||
| chunk.blocks.push(Default::default()); | |||
| chunk.blocks[0].mix(channels as u8); | |||
| chunk.blocks[0].repeat(channels as u8); | |||
This comment has been minimized.
This comment has been minimized.
sdroege
Jun 26, 2018
Contributor
You probably want to also signal the actual channel layout to GStreamer via the channel-mask or the positions array in the GstAudioInfo
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Manishearth
Jun 26, 2018
Author
Member
Oh, I see. I'll be working on this when I add better support for output channel counts. Currently it's hardcoded to be two.
servo-media/src/audio/block.rs
Outdated
| self.resize_silence(channels); | ||
| } | ||
| } else { | ||
| // For speakers, we have to do special things based the |
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Manishearth commentedJun 26, 2018
Haven't yet written tests for this partially because I don't have quad/5.1 systems to test with.
r? @ferjm