Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFirst bits of audio graph #6
Merged
Conversation
…tractions
|
r? @Manishearth We can chat about this tomorrow if you have any doubts about the patch. Thanks! |
ferjm
changed the title
|
@philn I would also love to hear your feedback on this. Thanks :) |
|
overall the design of the sink may need to change but we should first do the graph before we try this. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
ferjm commentedMay 17, 2018
•
edited
This moves the hard-coded oscillator out of the src element and the audio processing to its own thread.