Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support fan-in, fan-out, multiple connections between nodes #70

Merged
merged 5 commits into from Jul 4, 2018

Conversation

Projects
None yet
2 participants
@Manishearth
Copy link
Member

commented Jul 3, 2018

This adds support for ports to fan in and fan out, mixing on fan-in.

This is done by making individual Edges hold multiple Connections,
which enumerate different port pairs. Typically each edge will only have a
single connection.

r? @ferjm

based on #69 (first two commits)

fixes #68

Manishearth added some commits Jul 3, 2018

Invert edge direction
(part of #68)

We currently have the edges going in the reverse direction as the audio,
which is confusing. The reason we did this was so that we could use the
DFSPostOrder iterator.

This inverts their direction so that edges now go from source to sink,
and uses a `Reversed` adaptor to fix it.

@Manishearth Manishearth changed the title [WIP] Support fan-in, fan-out, multiple connections between nodes Support fan-in, fan-out, multiple connections between nodes Jul 4, 2018

Manishearth added some commits Jul 3, 2018

Support fan-in, fan-out, multiple connections between nodes
This adds support for ports to fan in and fan out, mixing on fan-in.

This is done by making individual `Edge`s hold multiple `Connection`s,
which enumerate different port pairs. Typically each edge will only have
a single connection.

fixes #68
@ferjm

ferjm approved these changes Jul 4, 2018

/// https://webaudio.github.io/web-audio-api/#dom-audionode-disconnect-output
// /// Disconnect all outgoing connections from a node's output
// ///
// /// https://webaudio.github.io/web-audio-api/#dom-audionode-disconnect-output

This comment has been minimized.

Copy link
@ferjm

ferjm Jul 4, 2018

Member

Did you forget to uncomment this?

/// https://webaudio.github.io/web-audio-api/#dom-audionode-disconnect-destinationnode-output-input
// /// Disconnect all outgoing connections from a node's output to another node's input
// ///
// /// https://webaudio.github.io/web-audio-api/#dom-audionode-disconnect-destinationnode-output-input

This comment has been minimized.

Copy link
@ferjm

ferjm Jul 4, 2018

Member

Ditto

@ferjm ferjm merged commit 475b828 into master Jul 4, 2018

@ferjm ferjm deleted the fan branch Jul 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.