Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upSupport fan-in, fan-out, multiple connections between nodes #70
+266
−84
Conversation
(part of #68) We currently have the edges going in the reverse direction as the audio, which is confusing. The reason we did this was so that we could use the DFSPostOrder iterator. This inverts their direction so that edges now go from source to sink, and uses a `Reversed` adaptor to fix it.
Manishearth
changed the title
| /// https://webaudio.github.io/web-audio-api/#dom-audionode-disconnect-output | ||
| // /// Disconnect all outgoing connections from a node's output | ||
| // /// | ||
| // /// https://webaudio.github.io/web-audio-api/#dom-audionode-disconnect-output |
This comment has been minimized.
This comment has been minimized.
| /// https://webaudio.github.io/web-audio-api/#dom-audionode-disconnect-destinationnode-output-input | ||
| // /// Disconnect all outgoing connections from a node's output to another node's input | ||
| // /// | ||
| // /// https://webaudio.github.io/web-audio-api/#dom-audionode-disconnect-destinationnode-output-input |
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Manishearth commentedJul 3, 2018
•
edited
This adds support for ports to fan in and fan out, mixing on fan-in.
This is done by making individual
Edges hold multipleConnections,which enumerate different port pairs. Typically each edge will only have a
single connection.
r? @ferjm
based on #69 (first two commits)
fixes #68