Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUnify setparam methods, various cleanups #78
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Manishearth commentedJul 9, 2018
This adds a ParamType that lets us talk about AudioParams in a unified way. From the DOM side an
AudioParamcan now just be a(NodeId, ParamType)pair.In the future we can use this to talk of connecting nodes to audio params as well, as an variant of PortId.
I also did some cleanups, marking engine-related things crate-public (script should never create engines), and renaming
AudioNodeTypetoAudioNodeInit(this will require a rename in the DOM code) to better reflect what it does.AudioNodeTypenow exists as a bare enum for debugging purposes.r? @ferjm