Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upSplit up crates to facilitate backend switching #84
Conversation
servo-media-audio/src/node.rs.orig
Outdated
| @@ -0,0 +1,225 @@ | |||
| <<<<<<< HEAD:servo-media-audio/src/node.rs | |||
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
I had to git merge just because rebasing was throwing up way too many merge conflicts. |
|
\o/ I swear I had an eureka! moment last night about this approach and now I wake up and see that you already implemented it! :D! Thanks! |
|
I'd kinda mentioned this last week but I didn't really explain it well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Manishearth commentedJul 11, 2018
•
edited
This gets rid of the gst feature, instead using target-switching to select the backend.
The servo-media crate is a thin wrapper that does all the backend switching. The GStreamer backend is
now in the servo-media-gstreamer crate, and all of the audio stuff is in the servo-media-audio crate.
You use the crate the same way (one small difference, in accordance to rust style you will have to import the crate as
servo-mediain Cargo.toml), and it automatically picks the backend based on the platform.This makes it pretty easy to swap backends as well; adding a new backend can be done with a cargo feature, and once we fix the android stuff we can make this unconditional.
r? @ferjm