Skip to content

/ media

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for connecting nodes to params #89

Merged
merged 4 commits into from Jul 19, 2018
Merged

Add support for connecting nodes to params #89

merged 4 commits into from Jul 19, 2018
+229 −33

Conversation

@Manishearth
Copy link
Member

Manishearth commented Jul 19, 2018

Since the AudioListener stuff is in flux I figured I'd get this out of the way. Was pretty straightforward.

Todo: Fill in disconnect() impls for this

r? @ferjm
Manishearth added 2 commits Jul 18, 2018
@Manishearth
Add unused support for param indexed inputs
749bcf3 
This adds all the types for param indexed inputs, and makes everything
work with them, but doesn't actually do anything with connections to
such inputs.
@Manishearth
Fill in support for mixing in inputs connected to audio params
7b2f836
@Manishearth Manishearth force-pushed the param-connect branch from 9fea0fc to 9682592 Jul 19, 2018
@ferjm
ferjm approved these changes Jul 19, 2018
View changes
Copy link
Member

ferjm left a comment

Nice!

There is a git merge leftover though: examples/Cargo.toml.orig
examples/Cargo.toml.orig Outdated
@@ -0,0 +1,42 @@
[package]

This comment has been minimized.

Sign in to view
@ferjm

ferjm Jul 19, 2018

Member

Oops :)
audio/src/graph.rs
// we ensure that the PortIndex enum has zero overhead for outputs,
// taking up no extra discriminant space and eliminating PortIndex::Param
// branches entirely from the compiled code
type ParamId = !;

This comment has been minimized.

Sign in to view
@ferjm

ferjm Jul 19, 2018

Member

/me learns about never types
Manishearth added 2 commits Jul 19, 2018
@Manishearth
Add example for connecting params to nodes
17cbde0
@Manishearth
Add disconnect support
eeac674
@Manishearth Manishearth force-pushed the param-connect branch from 9296a47 to eeac674 Jul 19, 2018
@Manishearth Manishearth merged commit 51f69d1 into master Jul 19, 2018
@Manishearth Manishearth deleted the param-connect branch Jul 19, 2018
@ferjm ferjm mentioned this pull request Jul 31, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ferjm ferjm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@Manishearth @ferjm
You can’t perform that action at this time.