Add support for connecting nodes to params #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds all the types for param indexed inputs, and makes everything work with them, but doesn't actually do anything with connections to such inputs.
Manishearth
force-pushed
the
param-connect
branch
from
9fea0fc
to
9682592
Compare
ferjm
approved these changes
Jul 19, 2018
examples/Cargo.toml.orig
Outdated
| @@ -0,0 +1,42 @@ | |||
| [package] | |||
| // we ensure that the PortIndex enum has zero overhead for outputs, | ||
| // taking up no extra discriminant space and eliminating PortIndex::Param | ||
| // branches entirely from the compiled code | ||
| type ParamId = !; |
There was a problem hiding this comment.
/me learns about never types
Manishearth
force-pushed
the
param-connect
branch
from
9296a47
to
eeac674
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the AudioListener stuff is in flux I figured I'd get this out of the way. Was pretty straightforward.
Todo: Fill in
disconnect()impls for thisr? @ferjm