Skip to content

/ media

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix processing of params for oscillator nodes #94

Merged
merged 3 commits into from Jul 20, 2018
Merged

Fix processing of params for oscillator nodes #94

merged 3 commits into from Jul 20, 2018

Conversation

@Manishearth
Copy link
Member

Manishearth commented Jul 20, 2018

This was a bit buggy

r? @ferjm
Manishearth added 3 commits Jul 20, 2018
@Manishearth
Fix oscillator node updates
e5b650d
@Manishearth
Don't skip nodes without inputs since they may have params
00ec1b3
@Manishearth
Example for connect() to frequency
e1c5d68
@ferjm
ferjm approved these changes Jul 20, 2018
View changes
@ferjm ferjm merged commit ca631b1 into servo:master Jul 20, 2018
@ferjm ferjm deleted the Manishearth:param-fix branch Jul 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ferjm ferjm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@Manishearth @ferjm
You can’t perform that action at this time.