Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upSupport for offline context #95
Merged
+254
−22
Conversation
audio/src/render_thread.rs
Outdated
| @@ -32,22 +34,31 @@ pub enum AudioRenderThreadMsg { | |||
|
|
|||
| pub struct AudioRenderThread<B: AudioBackend> { | |||
| pub graph: AudioGraph, | |||
| pub sink: B::Sink, | |||
| pub sink: Box<AudioSink>, | |||
This comment has been minimized.
This comment has been minimized.
Manishearth
Jul 25, 2018
Member
Can we have an enum here instead?
pub enum Sink<B> {
Play(B),
Offline(OfflineAudioSink)
}
and then just implement AudioSink on this enum too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
ferjm commentedJul 24, 2018
I made the new offline context implement the existing AudioSink trait so we can reuse the current render thread processing algorithm.
r? @Manishearth