Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upBuild libEGL.dll on Windows #15
Merged
+128
−16
Conversation
|
r? @asajeffrey |
|
I'm not sure why the linking test is disabled, perhaps add a comment? Apart from that, LGTM. You can r=me. |
|
|
||
| cmd.arg("/wd4100"); | ||
| cmd.arg("/wd4127"); | ||
| cmd.arg("/LD"); |
This comment has been minimized.
This comment has been minimized.
| @@ -13,12 +13,13 @@ fn test_linkage() { | |||
| init(); | |||
| } | |||
|
|
|||
| #[cfg(all(windows, feature = "egl"))] | |||
| // This test needs to perform dynamic linkage checks on the generated libEGL.dll. | |||
| /*#[cfg(all(windows, feature = "egl"))] | |||
This comment has been minimized.
This comment has been minimized.
|
@bors-servo r=asajeffrey |
|
|
bors-servo
added a commit
that referenced
this pull request
Mar 11, 2019
|
|
bors-servo
added a commit
that referenced
this pull request
May 9, 2019
This comment has been minimized.
This comment has been minimized.
|
@jdm why was this removed? It's used by WR's |
This comment has been minimized.
This comment has been minimized.
|
I'm not sure! It might have been an accident. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
jdm commentedMar 9, 2019
•
edited
This separates the shared library from the static ANGLE library so glutin can support ANGLE transparently. Fixes #14.