Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build libEGL.dll on Windows #15

Merged
merged 4 commits into from Mar 11, 2019

Conversation

Projects
None yet
3 participants
@jdm
Copy link
Member

jdm commented Mar 9, 2019

This separates the shared library from the static ANGLE library so glutin can support ANGLE transparently. Fixes #14.

jdm added some commits Mar 9, 2019

@jdm

This comment has been minimized.

Copy link
Member Author

jdm commented Mar 11, 2019

@asajeffrey
Copy link
Member

asajeffrey left a comment

I'm not sure why the linking test is disabled, perhaps add a comment? Apart from that, LGTM. You can r=me.


cmd.arg("/wd4100");
cmd.arg("/wd4127");
cmd.arg("/LD");

This comment has been minimized.

Copy link
@asajeffrey

asajeffrey Mar 11, 2019

Member

I heart Windows build configuration.

@@ -13,12 +13,13 @@ fn test_linkage() {
init();
}

#[cfg(all(windows, feature = "egl"))]
// This test needs to perform dynamic linkage checks on the generated libEGL.dll.
/*#[cfg(all(windows, feature = "egl"))]

This comment has been minimized.

Copy link
@asajeffrey

asajeffrey Mar 11, 2019

Member

Why is this test no longer working?

@jdm

This comment has been minimized.

Copy link
Member Author

jdm commented Mar 11, 2019

@bors-servo r=asajeffrey

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Mar 11, 2019

📌 Commit f76610a has been approved by asajeffrey

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Mar 11, 2019

⌛️ Testing commit f76610a with merge 1442828...

bors-servo added a commit that referenced this pull request Mar 11, 2019

Auto merge of #15 - servo:windows-shared, r=asajeffrey
Build libEGL.dll on Windows

This separates the shared library from the static ANGLE library so glutin can support ANGLE transparently. Fixes #14.
@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Mar 11, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: asajeffrey
Pushing 1442828 to master...

@bors-servo bors-servo merged commit f76610a into master Mar 11, 2019

1 of 3 checks passed

continuous-integration/appveyor/branch Waiting for AppVeyor build to complete
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.