Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate to m-c f1082516d62f3b8ff6ed1ec44c1e2328bd2a3977 #17
Conversation
|
We are a bit blocked on using Wrench on Windows for replaying captures with dual-source blending... |
|
Try adding |
| @@ -18,7 +18,7 @@ fn build_egl(target: &str) { | |||
|
|
|||
| let mut build = cc::Build::new(); | |||
|
|
|||
| let data = build_data::EGL; | |||
| let data = build_data::ANGLE; | |||
This comment has been minimized.
This comment has been minimized.
jdm
May 9, 2019
Member
I'm concerned that some of these changes seem to revert the changes from #15 that generated libEGL.dll separates from the rest of angle on windows.
This comment has been minimized.
This comment has been minimized.
kvark
May 9, 2019
Author
Member
Yes, that's a fair concern. I don't know much about what this is meant to do, and I didn't try to investigate further. I see that the script no longer generates EGL constant, so not sure how build.rs is supposed to work?
This comment has been minimized.
This comment has been minimized.
jdm
May 9, 2019
Member
I didn't realize that build_data was generated, so I didn't update the script. My changes in #15 separated the libEGL parts of the build from the rest of angle, producing a DLL which could be used by Servo. This replicates the effect of the moz.build setup that Gecko uses to produce it as well.
This comment has been minimized.
This comment has been minimized.
kvark
May 9, 2019
Author
Member
I see. So it sounds like #15 needs to be mostly rewritten to affect the generate_build_data.py instead of build_data.rs
|
|
|
Rebased now, PTAL. |
|
Travis is very unhappy. We may need to use clang instead of gcc, or use a more recent std=c++ flag than 11? |
|
Lots more unhappiness. |
|
Windows and mac are hitting a problem running tests:
Linux is still stuck on a collision with libc math macros:
|
|
Trying to update the generated bindings yielded:
|
|
Updating the bindings made macOS and Windows tests pass. Just need to figure out how to work around the build problem on linux now. |
|
The
|
|
Everything passed! The secret was upgrading CI to xenial and therefore a newer clang. |
|
r? @kvark |
|
Amazing work, thanks @jdm ! |
|
|
Update to m-c f1082516d62f3b8ff6ed1ec44c1e2328bd2a3977
|
|
kvark commentedMay 9, 2019
No description provided.